search

joeydumont / wignerSymbols

A C++ library to compute the Wigner 3j- and 6j- symbols (with FORTRAN backend).
GNU Lesser General Public License v3.0
30 stars 15 forks source link

Fix compiler warnings #6

Closed hmenke closed 6 years ago

hmenke commented 6 years ago

The code caused several compiler warnings, which I fixed. I also added more warning levels to the CMake file. On top of that I specified -Werror to prevent the introduction of new warnings.

The code can be automatically built and tested on Travis CI. Code coverage is automatically determined and uploaded to CodeCov.

Optionally you can add these badges to your README. Build status Code coverage report Those badges of course point to my repo, below is the markdown you'd have to insert for your own.

[![Build status](https://travis-ci.org/valandil/wignerSymbols.svg?branch=master)](https://travis-ci.org/valandil/wignerSymbols)
[![Code coverage report](https://codecov.io/gh/valandil/wignerSymbols/branch/master/graph/badge.svg)](https://codecov.io/gh/valandil/wignerSymbols)
joeydumont commented 6 years ago

Thanks for this!

Removing the arrays and exclusively using std::vector is a good idea. I have no clue why I wrote it like that back then.

hmenke commented 6 years ago

To activate Travis CI and CodeCov, just go to https://travis-ci.org/ and https://codecov.io/ and login with your GitHub account. Then on Travis CI you have to activate the wignerSymbols repository but CodeCov will just work out-of-the-box.