search

joeyespo / grip

Preview GitHub README.md files locally before committing them.
MIT License
6.46k stars 424 forks source link

Grip 4.3.6 doesn't navigate Markdown Wiki-page links #228

Open sprossiter opened 7 years ago

sprossiter commented 7 years ago

As discussed in a StackOverflow comment, I have the latest Grip 4.3.6 installed on Win 10 x64.

With that, none of my Markdown links within my Wiki pages work (e.g., [link to page 1](Page1)). If I add the .md suffix they do work in Grip but that is not the correct GitHub format (doing that gets you to the source of the page rendered as HTML).

Am I doing something very strange here?

I actually explored the crazy world of Golem-supported GitHub Wiki links in this Wiki. Cloning that and running Grip on it (for me) gives the problem with the 'standard' link to Page2 from the home page. (I can understand if Grip didn't support all the other weirdness that Golem does... I also have the problem on 'real' Wikis as well.)

lsrdg commented 7 years ago

Experiencing the same on Linux, I thought it was an "expected" behaviour though, and just got used to ctrl-f around.

Am I doing something very strange here?

Asking myself the same question. :/

sprossiter commented 7 years ago

Experiencing the same on Linux, I thought it was an "expected" behaviour though, and just got used to ctrl-f around.

OK, edited the title to remove the Windows-specifics. Good to know I'm not cracking up!

just got used to ctrl-f around.

Curious: how do you use Find (Ctrl-F) to navigate between-Wiki-page links?

lsrdg commented 7 years ago

OK, edited the title to remove the Windows-specifics. Good to know I'm not cracking up! 👍

Curious: how do you use Find (Ctrl-F) to navigate between-Wiki-page links?

I don't, just use Find to find header (link), but it would be nice to be able to navigate. :)

noah commented 6 years ago

Nginx-specific workaround:

 location / {                                                                            
                autoindex on;                                                                   
                try_files $uri $uri/ $uri.html =404;                                            
        }

$uri.html will look for (and render) file.html even if you just link to file.