search

joeyespo / grip

Preview GitHub README.md files locally before committing them.
MIT License
6.45k stars 423 forks source link

Support GitLab Markdown preview? #283

Open wuweiweiwu opened 5 years ago

wuweiweiwu commented 5 years ago

AFAIK its very similar. Some minor syntactic differences

joeyespo commented 5 years ago

Sounds good. Do you happen to know if GitLab offers an API for their Markdown rendering? If so, we could add a new GitLabRenderer (similar to GitHubRenderer).

wuweiweiwu commented 5 years ago

I believe so! https://docs.gitlab.com/ee/api/markdown.html

I'll be happy to pick this up and work on it in the coming weeks

joeyespo commented 5 years ago

Perfect!

Awesome. If you do, I'll be happy to get it in. Likely with a --gitlab argument for now since this project is still mainly a GitHub project. I do think it's beneficial to keep it focused. If the implementation gets complex, feel free to comment on that here and we can try to find a way to improve the internals first.

Thanks for offering 😃

roosemberth commented 5 years ago

Hi, I wonder what's the state of the issue?

wuweiweiwu commented 5 years ago

I havent had the time to make this particular change. I'd try to get it in when i have the bandwidth but feel free to pick it up! :)

Lucas-C commented 4 years ago

FYI, a PR was submitted to provide this : https://github.com/joeyespo/grip/pull/316