Open wuweiweiwu opened 5 years ago
Sounds good. Do you happen to know if GitLab offers an API for their Markdown rendering? If so, we could add a new GitLabRenderer
(similar to GitHubRenderer
).
I believe so! https://docs.gitlab.com/ee/api/markdown.html
I'll be happy to pick this up and work on it in the coming weeks
Perfect!
Awesome. If you do, I'll be happy to get it in. Likely with a --gitlab
argument for now since this project is still mainly a GitHub project. I do think it's beneficial to keep it focused. If the implementation gets complex, feel free to comment on that here and we can try to find a way to improve the internals first.
Thanks for offering 😃
Hi, I wonder what's the state of the issue?
I havent had the time to make this particular change. I'd try to get it in when i have the bandwidth but feel free to pick it up! :)
FYI, a PR was submitted to provide this : https://github.com/joeyespo/grip/pull/316
AFAIK its very similar. Some minor syntactic differences