joeyespo / grip

Preview GitHub README.md files locally before committing them.
MIT License
6.45k stars 423 forks source link

Make STYLE_URLS_SOURCE be configurable #290

Open idlem1nd opened 5 years ago

idlem1nd commented 5 years ago

Having API_URL configurable is really helpful for those of us in a firewalled environment so we can point to our own GitHub Enterprise server, however you get a later error when trying to download styles, as this always attempts to reach https://github.com/joeyespo/grip to grab the CSS from a README page.

I hacked constants.py to point to a GitHub page that is reachable from our network and everything works great:

STYLE_URLS_SOURCE = "https://git.mydomain.com/user/repo

Would it be possible to expose this as a setting so we can change it in ~/.grip/settings.py rather than needing to edit the source?

Thanks again for a useful tool!

hmuhammadazeem commented 5 years ago

Can I work on this issue?