search

joeyespo / grip

Preview GitHub README.md files locally before committing them.
MIT License
6.42k stars 423 forks source link

Add support for the XDG Base Directory Specification. #292

Open denisfa opened 5 years ago

denisfa commented 5 years ago

Hey @joeyespo.

This is a fix for #286. We adopt the solution as given by the table in this comment. The order of precedence is:

  1. ${GRIPHOME}/settings.py (if GRIPHOME is set)
  2. ~/.grip/settings.py (if ~/.grip exists)
  3. ${XDG_CONFIG_HOME:-~/.config}/grip/settings.py (fallback)

Also, the cache files are in ${XDG_CACHE_HOME:-~/.cache}/grip. I believe these files are not important at all for the user, hence I decided to not have a migration path for them.

Feel free to comment whatever you want about this.

alichtman commented 4 years ago

Hey @joeyespo, any update on this PR?

shinenelson commented 3 years ago

almost another year later, here is another person showing interest and support for this pull request to be merged. I checked this pull request ref out and tried it. It worked as expected for me. Can we please merge this pull request? I do not see any issues that is blocking it.

alichtman commented 2 years ago

Hey @joeyespo, can you merge this?

toh995 commented 2 years ago

I'd love to see this merged as well!