search

joeyespo / grip

Preview GitHub README.md files locally before committing them.
MIT License
6.42k stars 423 forks source link

`grip --quiet` does not seem to be quiet #293

Open ABrambleNinja opened 5 years ago

ABrambleNinja commented 5 years ago

Hi, Firstly, thanks for making this! I really appreciate this utility.

When I run grip doc/api-spec.md, it functions as expected:

$ grip doc/api-spec.md 
 * Serving Flask app "grip.app" (lazy loading)
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://localhost:6419/ (Press CTRL+C to quit)

However, when I give it the --quiet flag, it prints all of the above minus one line:

$ grip doc/api-spec.md --quiet
 * Serving Flask app "grip.app" (lazy loading)
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: off

I'm happy to submit a PR to fix this if this isn't intended behavior (if it is, then that's totally fine, just wanted to know!)

joeyespo commented 5 years ago

Yeah, I'd consider this a bug. Happy to take a fix. (Note that these messages come from Flask / Werkzeug.)

Thanks for the issue, @ABrambleNinja!