search

joeyespo / grip

Preview GitHub README.md files locally before committing them.
MIT License
6.42k stars 423 forks source link

True up templates to CSS (fixes #291). #297

Closed phyllisstein closed 5 years ago

phyllisstein commented 5 years ago

👋 Hey there! I happened to stumble over the selector drift nuisance in #291, and figured I'd take a crack at fixing it. The changes turned out to be pretty minor, unless I'm missing something.

Still need to clean up the test suite and do a visual audit of the user_content styling, but figured I'd throw a quick fix up in case anyone else gets bit.

Thanks for all your work on Grip! Don't know how anyone can stand the lesser GFM styles out there.

BEFORE

localhost_6419_ (1)

AFTER

localhost_6419_

TODO

joeyespo commented 5 years ago

Hey, @phyllisstein! This looks great! Thanks so much for diving in.

I'll merge it in, makes some tweaks, fix the --user-content, and fix the tests so you don't have to worry about doing that. (Just had to re-run tests/regenerate.py.) Then will release.

phyllisstein commented 5 years ago

Thanks a bunch for picking up my slack! My little sabbatical from GitHub was blissfully unproductive but awkwardly timed.