`safe_join` in Flask is deprecated

joeyespo / grip

Preview GitHub README.md files locally before committing them.

MIT License

6.47k stars 424 forks source link

`safe_join` in Flask is deprecated #359

Closed bryce-carson closed 2 years ago

bryce-carson commented 2 years ago

safe_join was recently deprecated in Flask, so the current version of Grip is now broken with a recent version of Flask.

freezed commented 2 years ago

Hello all :wave: I confirm this issue, on my Ubuntu:

❯ uname -a && lsb_release -a
Linux laptop 5.4.0-105-generic #119-Ubuntu SMP Mon Mar 7 18:49:24 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.4 LTS
Release:    20.04
Codename:   focal

I just try @bryce-carson commit ( ea229a56bcdf60a9dc25f7c5099a09f4dcb2c12f ) and confirm it fix the issue for me.

Thx :handshake:

fiblan commented 2 years ago

A quick&dirty workaround is install Flask==2.0.3, but @bryce-carson commit (ea229a5) definitely solves it.

joeyespo commented 2 years ago

Grip v4.6.1 with this fix has just been released. Thanks for the PR and quick fix, @bryce-carson!

Upgrade with pip install --upgrade grip.

Feel free to open another issue if there are still issues.