search

joeyespo / inbox-by-gmail-checker

Displays the number of unread messages in Inbox by Gmail. You can also click the button to open your inbox.
http://joeyespo.com/inbox-by-gmail-checker
MIT License
68 stars 11 forks source link

Added desktop notification feature. #17 closed #18

Closed dkhurshudian closed 7 years ago

joeyespo commented 7 years ago

Thanks for taking this on, @davo11122!

You did the hard part. Would you be up for adding this option to options.html too? If not, I'll pull this in and do that soon.

dkhurshudian commented 7 years ago

I'll do, but i need to know what should options.html contain.

joeyespo commented 7 years ago

Ok, awesome.

A checkbox under this one with label "Show Desktop Notifications" and help text "When checked, notifications will pop up when new email arrives."

Then you'll have to add code to persist the option in options.js (see useSnoozeColor for a working example), and make your new code conditional using the new option (example initialization, loading, and usage).

dkhurshudian commented 7 years ago

Done. we can include more details in notifiction popup(subjects, authors, etc..). what you think about it?

joeyespo commented 7 years ago

Thanks!

This looks good 👍

Thanks for address this, @davo11122 😃

joeyespo commented 7 years ago

Just released v4.0.0 which includes this feature.

Thanks again!

DaRkViVi commented 7 years ago

Would it be possible to have some more infos in the notification popup? Like sender, subject, a preview of the email text? Thanks!