search

joeyespo / inbox-by-gmail-checker

Displays the number of unread messages in Inbox by Gmail. You can also click the button to open your inbox.
http://joeyespo.com/inbox-by-gmail-checker
MIT License
68 stars 11 forks source link

Open in current tab if new tab? #19

Closed orschiro closed 7 years ago

orschiro commented 7 years ago

Dear @joeyespo,

What a great extension.

Thank you so much!

One request:

Is it possible to open the Inbox in the current tab if the current tab represents a new tab page?

Yours,

Robert

peek 2017-02-22 17-21-inbox checker

orschiro commented 7 years ago

Dear @joeyespo,

Can you please merge https://github.com/joeyespo/inbox-by-gmail-checker/pull/20 to address this? :-)

Yours,

Robert

joeyespo commented 7 years ago

Excellent! Thanks for the issue and taking this on, @orschiro 😄

joeyespo commented 7 years ago

I still haven't seen another extension do this since we last talked in #8 btw. I also personally like it opening in a new tab. So for those reasons, I made this optional and off by default. Feel free to turn it one after upgrading to 4.0.

joeyespo commented 7 years ago

Just released v4.0.0 which includes this feature.

Thanks again!

orschiro commented 7 years ago

Wow, cool.

Thanks for your quick release.

It's working perfectly with the optional setting. :-)

On Sun, Feb 26, 2017 at 6:26 AM Joe Esposito notifications@github.com wrote:

Just released v4.0.0 which includes this feature.

Thanks again!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joeyespo/inbox-by-gmail-checker/issues/19#issuecomment-282534191, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKbwxGQV2mwoQHa4IJoSBNrvsfGD5oxks5rgQzzgaJpZM4MI3NF .