joeyespo / inbox-by-gmail-checker

Displays the number of unread messages in Inbox by Gmail. You can also click the button to open your inbox.
http://joeyespo.com/inbox-by-gmail-checker
MIT License
68 stars 11 forks source link

Polling setting #5

Closed ghost closed 8 years ago

ghost commented 8 years ago

2

joeyespo commented 8 years ago

Thank you, @michliga! :smiley:

ghost commented 8 years ago

Thank you! @joeyespo

joeyespo commented 8 years ago

@michliga Made one tweak in 2bab1daeb61dfe27f026575d33759d00d8898514.

This allows the exponential backoff when the internet connection is lost, but has the side effect of one-check-per-hour be the maximum poll frequency now.

What do you think?

ghost commented 8 years ago

@joeyespo I can't imagine anyone would want the frequency to be more than an hour, so I think that's perfectly fine. I just wish there was a way to check more frequently than once per minute.

joeyespo commented 8 years ago

Excellent :+1:

Yeah, it'd be nice if there was a general way to be more realtime, like push notifications for web projects or something.

In this case, what if we removed the rounding step and allow decimal values in the options. This would obviously make the browser extension more chatty, but at least you'd get closer to realtime when you need it.

ghost commented 8 years ago

I think that would be awesome, I mean if it's too chatty one can change the setting. My personal preference would be to have it as close to real time as possible.

joeyespo commented 8 years ago

Ok, I started with fractional intervals in cbbbfaa17673794e2821af040549c3d3fbe958e8, but then decided it might be simpler to use seconds instead. Implemented in #6.

joeyespo commented 8 years ago

Just published v3.2.0 to the Chrome Web Store, which contains this fix. Thanks!