joeyism / py-edgar

A small library to access files from SEC's edgar
GNU General Public License v3.0
227 stars 52 forks source link

get_documents does not work #6

Closed auggunner closed 4 years ago

auggunner commented 4 years ago

I tried the three examples on https://pypi.org/project/edgar/

There is, however, one example that does not work:

from edgar import Company company = Company("Oracle Corp", "0001341439") tree = company.get_all_filings(filing_type = "10-K") docs = edgar.get_documents(tree, no_of_documents=5)

AttributeError: 'Edgar' object has no attribute 'get_documents'

joeyism commented 4 years ago

Whoops, in the new version you'll have to import get_documents like so:

from edgar.company import get_documents

i was thinking of changing that though, so if you have suggestions i'll take it

atbe commented 4 years ago

We should update the README.md to reflect this change. I'll submit a PR.

joeyism commented 4 years ago

@atbe submit a PR and i'll approve it

joeyism commented 4 years ago

Updated as of 5.0.0