search

joeyparrish / valheim-farmcounter

A Valheim mod for tracking farm population
GNU General Public License v3.0
1 stars 0 forks source link

Sign Range #3

Open Hotair10 opened 1 year ago

Hotair10 commented 1 year ago

Hey Joey, got another one for you. So this mod is supposed to reflect the range of the sign to match that of the workbench range. However with custom ranges (or the CraftingStationRange mod at least), you can set the range as 0 to be "unlimited" as in the loaded chunk. However when set to 0, it renders the Farm Counter to have 0 range, always displaying a zero. As I see it, Two solutions exist here. Either 0 range could also become unlimited with Farm Counter, or probably the more preferable option would be adding a config to Farm Counter itself, letting us specify a range for the signs to read.

joeyparrish commented 1 year ago

Ah, interesting. I'm honestly not convinced that unlimited range for the sign is a good idea. If we had to scan every monster in memory every time the sign's update loop runs, that might get expensive. (I haven't tried it.)

But I'll defer to you on that. If you want it, I guess you can try it out and see.

@Hotair10, are you interested in sending a PR to implement one of those solutions? You might want to start here: https://github.com/joeyparrish/valheim-farmcounter/blob/26fba7c9755328048ef1a65c1fac45818ff415ba/FarmCounter/FarmCounter.cs#L87-L93

Hotair10 commented 1 year ago

Honestly I'd just rather have Farm Counter with its own config file for range. That'd allow fine tuning for players if they want to have large ranges for their workbenches, but also have multiple similar farms near each other. Also lets people find what works best for them.

As much as I'd love to, I'm not really sure how to do the whole mod thing. I wouldn't know where to begin. I'm just hoping you agree with my suggestion enough to implement it 😅