(Github Notifications Dropdown) Conflicting collapsible blocks feature

joeytwiddle / code

All my old code in various languages. Some of it is better than the rest.

27 stars 6 forks source link

(Github Notifications Dropdown) Conflicting collapsible blocks feature #2

Closed jerone closed 7 years ago

jerone commented 7 years ago

Hi, loving your Github Notifications Dropdown userscript for the notifications dropdown. The hidden feature for collapsible blocks however not so much. It's actually conflicting with some other scripts I have installed. I don't want to edit the userscript and lose updates. So I was wondering if you want to remove that feature from this userscript (and maybe make a separate userscript from it)...

_https://openuserjs.org/scripts/joeytwiddle/Github_Notifications_Dropdown/issues/Conflicting_collapsible_blocks_feature_

joeytwiddle commented 7 years ago

Oh dear. These things do happen!

Actually GitHub has finally implemented collapsible files on some file/diff listings, so I could probably just remove this feature forever.

(The only disadvantage with Github's implementations are that the feature is on a little arrow v which is more effort to click that just clicking anywhere on the filename header. But I guess that's precisely the feature that is causing trouble for you!)

(Also I'm not sure if they have the feature on all listings with files. Maybe only on diffs at the moment.)

joeytwiddle commented 7 years ago

I have tried to disable it in f243806

jerone commented 7 years ago

Thanks, the update works great!