search

joeyvanlierop / xkcdbot

A reddit bot that automatically links xkcd comics in the /r/xkcd subreddit 🤖
MIT License
37 stars 20 forks source link

Implementation of Task "Reference comic by title/alias" #23

Closed stefanosporiazis closed 4 years ago

stefanosporiazis commented 4 years ago

I added functions in bot.py to handle comics requested by title and created a new table in the database to hold pairs of comic titles and comic numbers.

In order to keep the database updated with new comics, I made a new script which currently runs 24/7 and pulls new comics every 24 hrs (I tried doing this on the fly from within the bot, but it takes a lot of time to fully update the database the first time and that causes it to stop replying to comments until it finishes updating so I thought I would make a new script which can be run in parallel with the bot). I know there must be a better way to do this but I thought I should ask your opinion.

The update script takes a couple of hours (for me) to pull all the comics the first time it runs, but once it gets up to the latest comic, there's practically not delay.

I also made some small tweaks here and there.

joeyvanlierop commented 4 years ago

Thanks for the contribution! This looks fantastic, however you will have to give me a few days to double check everything before merging.

stefanosporiazis commented 4 years ago

Of course! Take your time. I'm still looking for bugs myself.

joeyvanlierop commented 4 years ago

I have made a few minor changes to this pull request, however I cannot push them. Would you mind checking off the box that allows edits from maintainers? Thanks

stefanosporiazis commented 4 years ago

Done.

joeyvanlierop commented 4 years ago

Thank you for your fantastic contribution and thank you also for your patience! I didn't intend to take this long to merge, however I have been quite busy trying to adapt to the crazy state that our world is in. Stay healthy!

stefanosporiazis commented 4 years ago

Sure, don't worry about it! Thank you for your kind words and I hope you're safe too!