search

joeyvanlierop / xkcdbot

A reddit bot that automatically links xkcd comics in the /r/xkcd subreddit 🤖
MIT License
37 stars 20 forks source link

Implementation of Issue #6 #24

Closed stefanosporiazis closed 4 years ago

stefanosporiazis commented 4 years ago

I tested it and it seems to work fine. Backwards ranges work the same way as normal ones (low to high id). The current implementation of numbers, ranges and titles matching is causing comics to appear in a weird order though. Don't know if we really care about the order they appear in but it could certainly look better.

We could sort the comic ids in ascending order but they would not appear in the order the user requests them. Otherwise we could find a better way to match numbers, ranges and titles so they don't mix.

joeyvanlierop commented 4 years ago

Thanks for the contribution, your changes look great! I really appreciate you adding the tests.