search

joeyvanlierop / xkcdbot

A reddit bot that automatically links xkcd comics in the /r/xkcd subreddit 🤖
MIT License
37 stars 20 forks source link

Comic #404 is not displayed properly #9

Closed jmeberlein closed 4 years ago

jmeberlein commented 4 years ago

find_comic(self, number) currently assumes that if the server returns a 404, that the comic doesn't actually exist and thus that the bot shouldn't display anything. However, as we all know, Randall purposefully skipped comic 404 as a nerdy joke, so that 404 error should be handled special.

joeyvanlierop commented 4 years ago

Fixed by #10

joeyvanlierop commented 4 years ago

For future reference, checking if comic 404 was referenced required a check against the string "404" rather than the number 404.

This was fixed in ed7c063d8f74932fae2cc768ab5d15ea36391388