search

joezuntz / cosmosis

Other
22 stars 16 forks source link

Update nautilus integration to 1.0 #119

Closed johannesulf closed 3 months ago

johannesulf commented 6 months ago

This PR should update the nautilus sampler integration to version 1.0. Currently, cosmosis actually only supports nautilus version 0.6. What was the reason for not supporting 0.7? By the way, the updates in 0.7 and 1.0 are fairly minor. Still, it would be good to update cosmosis to nautilus 1.0.

johannesulf commented 6 months ago

Looks like version 1.0.0 actually introduced a bug when handling blobs. That's what's causing the test failure. Cosmosis is handling blobs in a slightly unusual way that's currently not covered in any of my tests. I'll release a new version 1.0.1 soon and make sure that future versions of nautilus have tests for the way cosmosis handles blobs.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.02%. Comparing base (1ef5157) to head (dbf6648).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== - Coverage 61.03% 61.02% -0.01% ========================================== Files 115 115 Lines 11915 11919 +4 ========================================== + Hits 7272 7274 +2 - Misses 4643 4645 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johannesulf commented 6 months ago

Looks good now. The two test failures are due to me updating the cosmosis branch too quickly after publishing nautilus 1.0.1. In these two cases, pip still installed the older version 1.0.0.

joezuntz commented 4 months ago

Sorry for the delay on this - I'm on paternity leave but will be back in June to review.

joezuntz commented 3 months ago

Thanks for this!