joferkington / mpldatacursor

Interactive "data cursors" (a.k.a. annotation pop-ups) for matplotlib
MIT License
194 stars 47 forks source link

Merge Request #21

Closed jeremy-patterson1 closed 10 years ago

jeremy-patterson1 commented 10 years ago

I am new to matplotlib but I really like the functionality that it has. I noticed there was not a datacursor on the toolbar, so I made a feature request on the matplotlib git-hub site: https://github.com/matplotlib/matplotlib/issues/2965

They said your tool was a prime candidate but it would have to be merged into the main line: "We can not add an import of data-cursor-mode in the matplotlib source (as it presumably imports matplotlib) and circular dependencies are resolved by one of the least helpful exceptions I have seen python raise. Unless Joe want's to merge his project into the main line, there is not much we can do aside from making the toolbar plug-able."

Would you be ok with merging your project into the main line?

joferkington commented 10 years ago

Hi @jeremy-patterson1,

I responded on the matplotlib issue, as I wanted to keep the context of the discussion: https://github.com/matplotlib/matplotlib/issues/2965#issuecomment-40411806

In a nutshell, I'm certainly not opposed to merging the project in the long-term, but I'm not too sure it's a good idea in the short-term.

Thanks for the suggestion, regardless!