search

joffrey-bion / javafx-themes

Provides a dark version of the modena theme for JavaFX applications
MIT License
54 stars 28 forks source link

Potential licensing issues #3

Open shasheene opened 6 years ago

shasheene commented 6 years ago

For many, this may be overly diligent, but for others, this is an important point:

The original "modena.css" theme linked to in the docblock (https://gist.github.com/maxd/63691840fc372f22f470) has an Oracle copyright notice.

This GitHub project has an MIT license -- which is effectively relicensing material adapted from an "All rights reserved" with permission.

I suggest learning form and taking some inspiration from the copyrighted CSS, but write it completely from scratch without looking at the original file, to avoid copyright issues.

joffrey-bion commented 6 years ago

Hi @shasheene, good catch!

Thanks for pointing that out, I didn't realize that the initial file I took from a gist was copyrighted.

The thing is, this dark version of the theme is simply a bunch of CSS properties. If I recreated a file from scratch until I reached the exact same visual, it would use the same values for the same properties, which is kinda wasting time to end up in the same situation, minus the comments.

I have limited access to the internet for a couple weeks, but I'll look into this when I'm back. Maybe there is a way to solve this problem by tweaking the license and/or the file header.

Cheers, Joffrey