search

joffreynk / Module2-FInalMealCapstone

Javascript Group captsone is a project built with Joffrey and Vincent at Javascript Module completion. It has many functionalities where a user visit the home page. the application loades data from two APIs and display them on interface. when a user click on heart icon it increments the number of likes on that specific item. when a user click on comments button It shows project discription and its comments. it gives also the functionality of adding new comment to the Item
https://joffreynk.github.io/Module2-FInalMealCapstone/
6 stars 0 forks source link

Group capstone: set up your Kanban board #1

Open vabuyia opened 2 years ago

vabuyia commented 2 years ago

Group capstone: set up your Kanban board

In our Capstone Project, we are two students: 1). @vabuyia- Student A 2). @JoffreyNK -Student B

Descriptions have been included on each card on the Kanban board.

Each team member has been assigned the correct card.

Kanban board link

prolajumokeoni commented 2 years ago

Hi @Team 👋🏿 Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ No linter errors ✔️ Git flow was correctly used ✔️ Good design ✔️ Good PR title and Description

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

joffreynk commented 2 years ago

Hello, thank you for your feedback. But I didn't understand well how assigning cards can we change from students A to the appropriate name like Joffrey

On Mon, Jun 27, 2022 at 11:09 PM Oni Olajumoke Priscilla < @.***> wrote:

Hi @Team 👋🏿 Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! Highlights

✔️ No linter errors ✔️ Git flow was correctly used ✔️ Good design ✔️ Good PR title and Description Required Changes ♻️

-

Kindly make sure you used the tools to copy project correctly in the getting started section, currently, your cards don't have descriptions 👍🏿

Based on the requirements https://github.com/microverseinc/curriculum-javascript/blob/main/group-capstone/setup_kanban_board.md: each of the team members should assign themselves to the correct cards. Decide who will be the assignee for the cards marked as group tasks. All cards on your Kanban board should have assignees, please assign the cards on the board appropriately 👍🏿

Check the comments under the review. Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni https://github.com/prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

— Reply to this email directly, view it on GitHub https://github.com/JoffreyNK/Module2-FInalMealCapstone/issues/1#issuecomment-1167901378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQNBFQ4A6NZIW4ZM7CTHIK3VRIJ6ZANCNFSM5Z7Y6WWQ . You are receiving this because you were mentioned.Message ID: @.***>

AshakaE commented 2 years ago

Hi @JoffreyNK 🙋 ,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻️

image

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Davidosky007 commented 2 years ago

Hi @JoffreyNK 👋 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

[OPTIONAL]

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.