search

jofftiquez / vue-croppie

Vue wrapper for croppie
https://jofftiquez.github.io/vue-croppie/
MIT License
260 stars 42 forks source link

Added String as mouseWheelZoom's supported types #54

Closed guschnwg closed 5 years ago

guschnwg commented 5 years ago

Issue: screenshot from 2019-01-24 10-21-57

I added the type String as accepted by mouseWheelZoom property, as the documentation allows.

https://foliotek.github.io/Croppie/

dobromir-hristov commented 5 years ago

This should be an array...

jofftiquez commented 5 years ago

Thanks @guschnwg 👍

What do you mean @dobromir-hristov?

jofftiquez commented 5 years ago

@dobromir-hristov oh you mean the type? Yes, you are correct it should be an array. Although maybe using a pipe to separate the types could work? Have you tested it @guschnwg?

jofftiquez commented 5 years ago

@guschnwg can you check this. According to the docs it should be an array.

guschnwg commented 5 years ago

Both ways work. But i followed the docs, as @dobromir-hristov said.

Also, @jofftiquez i was able to test in my application, and it worked both ways

dobromir-hristov commented 5 years ago

Don't know. Just tried it and I got no prop validation what so ever.

guschnwg commented 5 years ago

@dobromir-hristov https://github.com/guschnwg/vue-croppie/tree/test check this example, just yarn install then yarn serve

jofftiquez commented 5 years ago

Thanks @guschnwg PR appreciated!

burongtz commented 5 years ago

Hi @jofftiquez , I need :mouseWheelZoom="'ctrl'" but the actualization isn't in the compiled file.

Can you show me the version with this last change? please.

dobromir-hristov commented 5 years ago

You have to wait for a release, sorry.

jofftiquez commented 5 years ago

@burongtz kindly wait for the release. Sorry for so many delays.

jofftiquez commented 5 years ago

Hi all, I'm kinda busy this coming few days, but I would be able to work on all of the remaining issues and PRs once Im back. Sorry for the delays. Thank you.

burongtz commented 5 years ago

Thank you @jofftiquez , @dobromir-hristov i'm going to wait for a release.