search

jofftiquez / vue-croppie

Vue wrapper for croppie
https://jofftiquez.github.io/vue-croppie/
MIT License
260 stars 42 forks source link

enableResize seems to be always enabled #64

Open yennor opened 5 years ago

yennor commented 5 years ago

It seems to be always possible to resize the viewport. Even if I set :enableResize="false" explicitly. The viewport can still be resized.

gordonmckenzie commented 4 years ago

I had the same problem, but I seemed to have solved this by setting the default value of the enableResize prop in the VueCroppieComponent.js file within the src folder of the vue-croppie module itself as follows: - enableResize: { type: Boolean, default: false },

I still set the prop explicitly as you stated.

barrywoolgar commented 3 years ago

Hello, by setting the boolean option enableResize to "false" (with quotes) you are setting it to be a string value instead. Only the empty string "" will be evaluated to boolean false, all other values are regarded as true - you might as well be setting it to "definitely"

Edit: You know what, I didn't spot this was a vue repo, so perhaps that's a perfectly normal way to set booleans. Sorry, I got lost and thought I was was still on the vanilla croppie repo.

jofftiquez commented 3 years ago

OMG how did I missed this issue? WTH I'm terribly sorry. I was writing my response and realized it was created May 31, 2019. I'm blown. :disappointed: I will look into this soon.

tonywei92 commented 3 years ago

@jofftiquez is it fixed tho? mine on v2.0.2 not working yet.