Add new method addGreatCircle to PathOverlay

[GoogleCodeExporter]

See this discussion: 
https://groups.google.com/d/topic/osmdroid/ZCrg59L4qB0/discussion

Original issue reported on code.google.com by neilboyd on 12 Apr 2012 at 9:24

[GoogleCodeExporter]

I added PathOverlay.addGreatCircle() in revision 1091.
I made one change - to call to other overload of addPoint()

I didn't add getBoundingBoxE6() or the sample because I think these are a bit 
specific to your use case. Perhaps I could add a sample similar to the other 
samples, or someone else could do that.

I think it would be better if you could remove the parameter numberOfPoints and 
let the method calculate how many points it needs without the caller having to 
calculate it. That should be easy enough - just copy the code that you had in 
your sample.

Original comment by neilboyd on 12 Apr 2012 at 9:36

[GoogleCodeExporter]

No sooner said than done! I added an overload that calculates numberOfPoints in 
revision 1092.

Original comment by neilboyd on 12 Apr 2012 at 9:40

[GoogleCodeExporter]

Glad to see you added my suggestion.

The overload is a good idea.
You just need to update the overloaded method javadoc comment to remove the 
referral to numberOfPoints.

The original method (where numberOfPoints can be defined) would still be 
required if the great circle path was a short path - a few hundred kms for 
example would only be drawn with a few points.

Original comment by warwo...@gmail.com on 15 Apr 2012 at 11:04

[GoogleCodeExporter]

This issue was closed by revision r1093.

Original comment by neilboyd on 16 Apr 2012 at 5:07

• Changed state: Fixed