jogboms / flutter_spinkit

✨ A collection of loading indicators animated with flutter. Heavily Inspired by http://tobiasahlin.com/spinkit.
MIT License
3.02k stars 308 forks source link

Custom Painters! #55

Open jogboms opened 5 years ago

jogboms commented 5 years ago

Planning on a complete rewrite from animated Widgets to CustomPaints. I believe this would have some improved performance. Anyone can help out if need be.

aagarwal1012 commented 5 years ago

@jogboms, it seems like a nice plan.

jogboms commented 5 years ago

It will take some amount of effort too 👍

payam-zahedi commented 4 years ago

Hi @jogboms , if it's possible I want to work on it. And my question is what should happen to the itemBuilder parameter? should we remove it or anything else?

jogboms commented 4 years ago

Hey @payam-zahedi

I really haven't given it too much thought as I would want it to be as clean and extendable as it can be with every information we have gathered so far.

Hoping one day, I'd have a free couple of day to give it the first push. I wouldn't mind if you do and then we review and extend it together. I have delayed for too long now indeed.

jogboms commented 4 years ago

I should have added this earlier. As @payam-zahedi mentioned, in order to remove the use of composed widgets, we would have to let go of the itemBuilder parameter. I don't know how the community would feel about this as I know the feature was requested and its been used already by many.