search

jogendra / LoadingShimmer

An easy way to add a shimmering effect to any view with just one line of code. It is useful as an unobtrusive loading indicator.
https://jogendra.dev/
MIT License
1.59k stars 74 forks source link

When using Pod, not able to access access class due to internal access #25

Closed Rashesh-Bosamiya closed 5 years ago

Rashesh-Bosamiya commented 5 years ago

I integrated using Pod, but couldn't able to access LoadingShimmer class due to default internal access of class.

I made public access to that class by putting public keyword.

public class LoadingShimmer: NSObject {
    public static let shared = LoadingShimmer()

    public class func startCovering(_ view: UIView?) {
        shared.coverSubviews(view)
    }

    public class func stopCovering(_ view: UIView?) {
        shared.removeSubviews(view)
    }

}

Would you please do the same changes in repo.

Thanks.

jogendra commented 5 years ago

Thank you @Rashesh-Bosamiya for opening the issue. I will make it public class, it was a silly mistake.

jogendra commented 5 years ago

Fixed in https://github.com/jogendra/LoadingShimmer/commit/f04bfef6e7353b8352ae8d31d571d5519ffd403b