jogeuncheol / Death_Counter

Auto counting your death in Elden Ring, Dark Souls (1, 2, 3), Sekiro : Shadows die twice, Demon's Souls Remake.
16 stars 0 forks source link

Program error on launch #4

Open AegisStormlock opened 2 years ago

AegisStormlock commented 2 years ago

Death_Counter_Error

jogeuncheol commented 2 years ago

Thank you for issue!

can you check a new commit? I have modified it to specify the path.

output_path = os.getcwd().replace('\\', '/') + '/유다희.txt'

and if not fixed I try harder. Thank you :D

AegisStormlock commented 2 years ago

Anti-Virus Stopping Program on Launch

Same issue but noticed this time that my Anti-Virus might be the one hindering the program. May I ask what your program does that might make one's anit-virus jump into action?

jogeuncheol commented 2 years ago

I think add except SOULS_DC.py script file in avast vaccine. If it doesn't work, Would you like to rename the text to English? like 유다희.txt -> youdied.txt in script Or do you want to run Python as an administrator?

I will upload a new commit, try pull and run script. Thank you! if still not working, I will check my script other computer.

AegisStormlock commented 2 years ago

Now Working

Adding an exception to SOULS_DC.py in my anti-virus didn't work. But adding one to SOULS_DC_22.03.exe did work.

The program runs and works. It writes the deaths in 유다희.txt, which yes - would be nice if was named youdied.txt

My one other feedback is that it starts at 0 every time you start it up and doesn't remember the deaths from the previous session. Would it be possible for it to start at the death count from the previous time you used it?

Also just wanna make sure. Can one get banned from online play by using this program?

Amazing work! Hope it can get the few changes, that would make it awesome :)

jogeuncheol commented 2 years ago

Thank you for feedback!

I rename output file name is you_died.txt the new commit version. but, The 유다희 is a kind of meme that calls YOU DIED in Korea. The pronunciation of 'YOU DIED' came from the similarity to 'Yoo Da-hee' == '유다희'.

Q. Would it be possible for it to start at the death count from the previous time you used it? A. I'll try to revise it by reflecting your feedback! I will include in new release.

Q. Can one get banned from online play by using this program? A. I don't think that's ever going to be the case. You don't modify or touch any of the game's data, you just capture the screen. This is the same as window capture or screenshot. It just scans the screen continuously.

asap I'll release new version. thank you !!

I'll look for more about the vaccine program.

I'm using Kaspersky on my computer, and when I used Pycharm IDE, there was no problem. I'll test it on another computer and share it with you when I get a solution! Or, let's ask the community!

Thank you!

jogeuncheol commented 2 years ago

Now Working

Adding an exception to SOULS_DC.py in my anti-virus didn't work. But adding one to SOULS_DC_22.03.exe did work.

The program runs and works. It writes the deaths in 유다희.txt, which yes - would be nice if was named youdied.txt

My one other feedback is that it starts at 0 every time you start it up and doesn't remember the deaths from the previous session. Would it be possible for it to start at the death count from the previous time you used it?

Also just wanna make sure. Can one get banned from online play by using this program?

Amazing work! Hope it can get the few changes, that would make it awesome :)

Thank you for feedback!

I rename output file name is you_died.txt the new commit version. but, The 유다희 is a kind of meme that calls YOU DIED in Korea. The pronunciation of 'YOU DIED' came from the similarity to 'Yoo Da-hee' == '유다희'.

Q. Would it be possible for it to start at the death count from the previous time you used it? A. I'll try to revise it by reflecting your feedback! I will include in new release.

Q. Can one get banned from online play by using this program? A. I don't think that's ever going to be the case. You don't modify or touch any of the game's data, you just capture the screen. This is the same as window capture or screenshot. It just scans the screen continuously.

I upload a new version. check out release! Thank you

AegisStormlock commented 2 years ago

Awesome! It remembers your previous deaths from the last session. Works really nice.

One last note would be: You said it works by window capture/screenshot. It sounds like something that would reduce the performance of the game. A by a very quick test I can see it does lower the fps of the game by a little bit. It's luckily nothing crazy. is it possible to optimize the death counter so it doesn't affect in-game performance?

Performace

I assume this is not an easy task and understand if not possible. Other than that it works great! Amazing job!

jogeuncheol commented 2 years ago

Awesome! It remembers your previous deaths from the last session. Works really nice.

One last note would be: You said it works by window capture/screenshot. It sounds like something that would reduce the performance of the game. A by a very quick test I can see it does lower the fps of the game by a little bit. It's luckily nothing crazy. is it possible to optimize the death counter so it doesn't affect in-game performance?

Performace

I assume this is not an easy task and understand if not possible. Other than that it works great! Amazing job!

That's a great question! I learned a lot from this project.

Capturing a computer's screen looks simple, but it's allocated quite a lot of resources. In particular, the higher the physical resolution, the more computer resources you need.

This program is based on FHD and is designed to operate at different resolutions. Capture the entire monitor at least once before making a YOUDIDE decision in all frames.

Higher resolution means larger data sizes mean more time to store and process data at once, and some frames can be lost.

Ideally, I think the capture performance is between 24 and 30 fps, but if necessary, you can reduce capture performance and minimize computer resources. Another option is to introduce a data processing schedule. You can process data sequentially in the queue. This method may not be updated immediately. I'll think about it.

In addition, I planning to make a YOU DIED classifier using deep learning. In this case, we expect to be more accurate than the current version.

I think it's worth solving. I will try to correct it as soon as possible. Thank you so much for helping me come up with a new idea.