search

jogold / cloudstructs

High-level constructs for AWS CDK
Apache License 2.0
165 stars 12 forks source link

chore(deps): remove deprecated dependencies and bump aws-cdk #256

Closed andreialecu closed 7 months ago

andreialecu commented 7 months ago

Fixes #255

BREAKING CHANGE: cloudstructs now requires aws-cdk-lib >= 2.112.0

andreialecu commented 7 months ago

Not exactly sure what to do about the integ:snapshots, I updated them and the test passes locally. I wonder if it's because of the gh runner differences vs my system.

andreialecu commented 7 months ago

Slightly offtopic: I also noticed something you may want to look into for the test infrastructure.

The GitHub workflow for testing updates the snapshots, too, while running the tests. This doesn't seem like something you'd want. Screenshot from recent workflow:

CleanShot 2024-02-23 at 12 15 17@2x

jogold commented 7 months ago

Slightly offtopic: I also noticed something you may want to look into for the test infrastructure.

The GitHub workflow for testing updates the snapshots, too, while running the tests. This doesn't seem like something you'd want. Screenshot from recent workflow:

This is the correct behavior, the "mutations" are then committed back, see

https://github.com/jogold/cloudstructs/blob/0ad4e6f8f53867e95aadb38ccdb27adb27ff4443/.github/workflows/build.yml#L55

https://github.com/projen/projen/blob/main/docs/publishing/build.md#self-mutation

jogold commented 7 months ago

Not exactly sure what to do about the integ:snapshots, I updated them and the test passes locally. I wonder if it's because of the gh runner differences vs my system.

Looking into this, usually fixed by running everything in a codespace.

andreialecu commented 7 months ago

Slightly offtopic: I also noticed something you may want to look into for the test infrastructure. The GitHub workflow for testing updates the snapshots, too, while running the tests. This doesn't seem like something you'd want. Screenshot from recent workflow:

This is the correct behavior, the "mutations" are then committed back, see

https://github.com/jogold/cloudstructs/blob/0ad4e6f8f53867e95aadb38ccdb27adb27ff4443/.github/workflows/build.yml#L55

projen/projen@main/docs/publishing/build.md#self-mutation

Yes, but what's the point of the test if the snapshots are always blindly updated? Seems easy to overlook.

jogold commented 7 months ago

Yes, but what's the point of the test if the snapshots are always blindly updated? Seems easy to overlook.

blindly updated but then reviewed in the PR

jogold commented 7 months ago

Thanks @andreialecu