search

joh-ann / whats-cookin

M2: Recipe Tracking Application
https://joh-ann.github.io/whats-cookin
2 stars 3 forks source link

Fix bug when user clicks on white space around tag images #40 #46

Closed alvarotorrestx closed 1 year ago

alvarotorrestx commented 1 year ago

Sorry my commit was done improperly last pull I did... I hope I closed and opened this properly now...

Here is what I last posted...

Hey there, I saw that this was self assigned after I had already tried working on it... I apologize ahead.. @joh-ann not sure if you completed it

But I wanted to help out, I went ahead and came up with a fix for issue #40

I commented out the old function in case you want to compare what happens between the event listener fix. The logic was a bit off and I went ahead and tested it in multiple scenarios but I'm sure more eyes than mine can find something more to fix or if it works, perfect!

Let me know your thoughts, thanks!

joh-ann commented 1 year ago

Thanks for doing this, Alvaro! We were able to practice dealing with merge conflicts when applying this fix as well. Appreciate the help!