search

johalun / sysctl-rs

A simplified Rust interface to the sysctl system call
MIT License
51 stars 23 forks source link

Update bitflags to v2 #64

Closed ydirson closed 1 year ago

ydirson commented 1 year ago

From https://github.com/bitflags/bitflags/releases/tag/2.0.0 the only breaking change appears to be on .bits

johalun commented 1 year ago

Hi and thanks for the PR. What will updating bitflags to v2 give us?

asomers commented 1 year ago

Hi and thanks for the PR. What will updating bitflags to v2 give us?

Probably nothing for "us". But most other crates have moved to bitflags 2, so if sysctl-rs upgrades as well, then other projects won't have to build bitflags twice.

asomers commented 1 year ago

For example, the following all use bitflags 2:

johalun commented 1 year ago

Thanks for the clarification! I'll merge this and get a new version pushed to crates.io.

asomers commented 1 year ago

What was up with the failure on nightly? It looked like a proc macro was out of date or something.