johanbernard / prestashop_to_dolibarr

THE prestashop to dolibarr in open source
33 stars 32 forks source link

Compatibility with last versions of Dolibarr and Prestashop #10

Open caos30 opened 4 years ago

caos30 commented 4 years ago

Hello, i'm very interested in your module. Obviously i need to synchronize a Dolibarr instance with a prestashop instance. My concern is regarding the compatibility of the module with the "last version" of Dolibarr and Prestashop. I really am not able to find this information. Looking at the Dolistore webpage of the module:

https://www.dolistore.com/es/modulos/497-Prestashop-to-Dolibarr-PRO--PJ-Conseil-.html

It says that only Dolibarr 3.9+ is compatible... but i would say looking in Github that its not true. So? This integration is for a customer of mine, so i can buy your module on Dolistore. I only need to know:

Thanks in advance! Sergi

johanbernard commented 4 years ago

Hello,

Thank you for your message :) Update the module for dolibar 10+ will probably not be very difficult,

First of all it need to update this : /dolipresta/lib/PSWebServiceLibrary.php for the variable constants to dialogue with prestashop

then you have to try if all is ok, and fix the problems if there is

that all :)

caos30 commented 4 years ago

Hello @johanbernard , after almost 2 weeks working on it intensively i've refactored several files of this double-model ;-)

The most important changes:

caos30 commented 4 years ago

Said all this, i have doubts about how do you want to manage all my changes (it really has been a rewrite of half od the code/files). I have no problem in doing a FORK to generate a PULL REQUEST. Although i would like -if you see possible- to be added as a trusted contributor of this project, if you wants after the integration of the PULL REQUEST.

I'm github user since several years, but i really don't have very experience on administration tasks, so please, choose what you think better.

I talk about this question because i will need do a lot of improvements in the next months and so, for be easy to you and me to maintain a unique repository with the minimum effort.

Cheers! And thanks for your initial work. It's a wonderful module. but we can get it grow!

wdammak commented 4 years ago

@caos30 We were looking forward your contrubition!(PR) I could help you on some subjects with this confinement....

caos30 commented 4 years ago

Ok, @wdammak , following your suggestion i've made now a fork and a pull request with my changes. I explain the details on the PR comment.

lainwir3d commented 3 years ago

Hi everyone.

A bit of topic hijacking, but not much (sorry). Following caos30 work on Dolibarr 10.x compatibility, how much work would you think would be required to have a 12.x compatibility? Any pointers on where should I start?

Cheers!

caos30 commented 3 years ago

Hello @lainwir3d i've upgrading this week some other modules (of mine) from Doli 10.x to 12.x and usually the needed changes are almost ZERO. Maybe you don't know, but the official developer team of Dolibarr generate a new major version of Dolibarr almost each 6 months, so the changes usually are minimal, or are very focused in a few of the core modules. So in other words... is usually quite fast to upgrade your modules from previous versions.

If you can try it do this: 1) install the module on a Dolibarr 12.x instance and 2) test the good running of the module, fixing any "bug" or "disadjustement" you see.

Welcome to this interesting module to have an integration with Prestashop!

lainwir3d commented 3 years ago

Hi @caos30, thanks for the swift answer! I'll check it out then.