johanberntsson / ozmoo

A Z-machine interpreter for the Commodore 64 and similar computers
GNU General Public License v2.0
114 stars 18 forks source link

Pressing ENTER at the prompt repeats the last command #17

Closed ZornsLemma closed 3 years ago

ZornsLemma commented 3 years ago

You can see this in the attached screenshot of Hollywood Hijinx; I did "LOOK" (which has scrolled off the screen) and then just pressed RETURN (the "empty" prompt about 1/3 of the way down the screen) and it was interpreted as a "LOOK" instead of giving a "[Beg pardon?]" message as it used to.

I think this may be something to do with the commented out code just after .parsing_done in text.asm, but I haven't dug too deeply into this.

Screenshot at 2020-10-16 23-48-05

(I am seeing this with commit 183b8e9b248ce32fe681bf49b367022f4b309714.)

johanberntsson commented 3 years ago

Thanks for the report. Your guess was correct, and it has now been fixed. (We are changing memory access to make better Plus/4 and C128 ports)

ZornsLemma commented 3 years ago

Great, thanks! The memory access changes look quite cool, but I'm holding back on trying to merge them until it's all settled down...

johanberntsson commented 3 years ago

Good idea to wait a bit. We're only halfway yet.

On Sat, 17 Oct 2020 at 22:41, ZornsLemma notifications@github.com wrote:

Great, thanks! The memory access changes look quite cool, but I'm holding back on trying to merge them until it's all settled down...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/johanberntsson/ozmoo/issues/17#issuecomment-710974168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN2C43SRSRIVFKIQGJVZLSLGNKPANCNFSM4ST5AISQ .