johanberntsson / ozmoo

A Z-machine interpreter for the Commodore 64 and similar computers
GNU General Public License v2.0
117 stars 19 forks source link

Simplify z_exe_mode check #23

Closed ZornsLemma closed 3 years ago

ZornsLemma commented 3 years ago

Thanks for taking pull request #22, as discussed there I have simplified the code further by tweaking the position of the TIMING and PRINT_SPEED checks.

fredrikr commented 3 years ago

I think jmp $8000 should be jmp main_loop. That makes the intention of the code clearer. This is especially important when the code modification takes place somewhere else in the code, not right next to the code being modified. Plus, if you miss calling set_z_exe_mode in ozmoo.asm, the code will still work.

Apart from that, it looks good.

ZornsLemma commented 3 years ago

Thanks Fredrik, I've pushed a commit to the same branch with the $8000 changed.