search

johanbrandhorst / grpc-gateway-boilerplate

All the boilerplate you need to get started with writing grpc-gateway powered REST services in Go
MIT License
479 stars 83 forks source link

Install buf from releases #25

Closed johanbrandhorst closed 3 years ago

marcosnils commented 3 years ago

hey @johanbrandhorst mind sharing what's the reason behind this change? I liked having all my tooling around tools.go and now having curl scripts in my makefile to download / install binaries seems like a drawback. Would love to understand better ther reason behind this change.

Preciate all your work in buf and the example projects that you maintain around that :pray:

johanbrandhorst commented 3 years ago

Hi Marcos, thanks for reaching out! The only reason for the change was that some users were concerned that installing buf from source now requires Go 1.16, so I made the decision to change the script here to use the recommended installation path, which is to install from the binary releases.

Another concern with using the tool dependencies path is that all the dependencies of your tools become part of your dependency closure, which can sometimes lead to unexpected module versions being chosen by go modules. If you install from releases, it shrinks your dependency tree significantly (especially for a large project like buf).

Hope that makes sense and feel free to reach out on Gophers Slack or the Buf slack if you have anymore questions!

marcosnils commented 3 years ago

Hope that makes sense and feel free to reach out on Gophers Slack or the Buf slack if you have anymore questions!

Sure, thx!