search

johanbrandhorst / protobuf

GopherJS Bindings for ProtobufJS and gRPC-Web
MIT License
81 stars 16 forks source link

protoc-gen-gopherjs: Use webpack to resolve imports after generation #11

Closed johanbrandhorst closed 6 years ago

johanbrandhorst commented 6 years ago

This could remove the ugly sed replacing that's currently in-use.

See https://www.marwan.io/blog/wrapping-node-modules-with-gopherjs for some ideas.

johanbrandhorst commented 6 years ago

Fixed in master, updated protoc-gen-gopherjs README with tips for adopter.

norunners commented 6 years ago

Got a reference to the commit?

johanbrandhorst commented 6 years ago

https://github.com/johanbrandhorst/protobuf/commit/17192d4c1319852148d575b002786bec9f1e08c1 https://github.com/johanbrandhorst/protobuf/commit/374a20a9b021aeca05863acd5f23907aff5584ad

From a user point of view it's probably easier to look at the grpcweb-example repo: https://github.com/johanbrandhorst/grpcweb-example/commit/5caf1d67b220ec3b2b2cb5400346362327b5f1b4