Shower thought: Remove dependency on generated ProtobufJS files

johanbrandhorst / protobuf

GopherJS Bindings for ProtobufJS and gRPC-Web

MIT License

81 stars 16 forks source link

Shower thought: Remove dependency on generated ProtobufJS files #5

Closed johanbrandhorst closed 7 years ago

johanbrandhorst commented 7 years ago

The ProtobufJS files just call to jspb.Message etc, that stuff could.be done in the protoc-gen-gopherjs files themselves. Would probably require some experimentation first.

johanbrandhorst commented 7 years ago

Gonna take a stab at implementing this in https://github.com/johanbrandhorst/protobuf/tree/remove-dependency-on-generated-files

johanbrandhorst commented 7 years ago

Managed to get this to pass all my tests - still a bit of cleaning up to do in generate.go, but this is starting to look like a reality now!

johanbrandhorst commented 7 years ago

I'm sufficiently pleased with the current state of this to merge it into master. See #13