search

johancz / johan-charlez-web-project

This is the final project in the course "Web Development frontend" in the ".NET Developer" programme at Teknikhögskolan.
0 stars 0 forks source link

Documentation (Meta) #26

Closed johancz closed 3 years ago

johancz commented 3 years ago

A meta bug for everything documentation.

johancz commented 3 years ago

@gustavnyberg, is there any way you could take a quick look at the documentation up to this point and give feedback on what could be improved?

Thanks.

gustavnyberg commented 3 years ago

@johancz I will have a look a this tomorrow and let you know my findings. If you are available we might even be able to do it over Teams with a voice call and some screen sharing. 😉

johancz commented 3 years ago

@johancz I will have a look a this tomorrow and let you know my findings. If you are available we might even be able to do it over Teams with a voice call and some screen sharing. 😉

Thank you, I'll try to be available all day.

gustavnyberg commented 3 years ago

@johancz We will have a look at this tomorrow!

gustavnyberg commented 3 years ago

@johancz

Everything looks really awesome! Your logbook is a textbook example as well as your issue tracking, board and development process.

I would say that you could move Backlog swim lane to be the first on your board to better visualize whatever is in the pipe for the future and for the next upcoming sprint and to be pulled into 'To Do'.

The structure and architecture is also great with separation in different files and folders.

I think you are working great with commits and headline/content for them. They are the right size, have logic relations to each other and their content, and the commit comments/descriptions as spot on, contain the vital info, distinct and non repetitive. This will be highly appreciated by outside stakeholders and your fellow developer colleagues.

I have some real world advice regarding these workflows and processes that I can elaborate further outside this project. Perhaps you already know them, but I am fond of among other things stage, squash and that you apparently are able to format the commit message using GitHub Desktop. Not sure if they use Markup or whatnot.

I haven't been able to go through the code in detail. But it look very neat, well formatted and I can't imagine other that it does what it is suppose to.

You will go through your code in your video pitch and if anything is unclear after that I will simply sit down and have a simple video/voice conversation about it, to sort things out and to give you the ability to achieve what you are aiming for!

You are all aligned with the requirements for VG, do now it is all about keeping it together and keep up all the good work to and across the finish line and give the customer hell of a project pitch!

Given that I am pretty sure that our boss will give you both the promotion and that raise that comes with it!

Well done!

Do you feel like you know where you stand and what to do these last thrilling hours of the Project? If so please close this issue and move on with whatever you have your mind set on doing.

johancz commented 3 years ago

Thanks for taking the time to look at the project and for compiling all of this feedback, it is really meaningful. :)

I would say that you could move Backlog swim lane to be the first on your board to better visualize whatever is in the pipe for the future and for the next upcoming sprint and to be pulled into 'To Do'.

Done.

I have some real world advice regarding these workflows and processes that I can elaborate further outside this project. Perhaps you already know them, but I am fond of among other things stage, squash and that you apparently are able to format the commit message using GitHub Desktop. Not sure if they use Markup or whatnot.

Please do, I've tried to use markdown when writing my commit messages but it doesn't appear to have much effect, at least on Github.

Do you feel like you know where you stand and what to do these last thrilling hours of the Project? If so please close this issue and move on with whatever you have your mind set on doing.

Yes, thank you!