search

johanhaleby / occurrent

Unintrusive Event Sourcing Library for the JVM
https://occurrent.org
124 stars 16 forks source link

Remove logback from transitive dependencies #154

Closed gavvvr closed 8 months ago

gavvvr commented 8 months ago

When using Occurrent, there is a Logback coming transitively. I noticed that because now I want to switch to another SLF4J implementation in my project, and there is a warning that multiple implementations of SLF4J is found in classpath.

I inspected the dependencies graph and found out that some components of Occurrent bring Logback transitively. Occurrent as a library should not enforce or bring any particular logger implementation to consumers classpaths and should rather depend on SLF4J only.

johanhaleby commented 8 months ago

You're right, I picked logback because I thought everyone was using it today ;) But I'll try to change to slf4j instead.

johanhaleby commented 8 months ago

I've fixed it now (I think) :)

gavvvr commented 8 months ago

Hi @johanhaleby There was a linked PR from me about this. There is no need to include SLF4J at all in 3 out of 3 modules, because you do not even depend on it. Please see #155