search

johanhelsing / bevy_web_asset

Bevy asset loader that transparently supports loading over http(s)
Apache License 2.0
71 stars 17 forks source link

Johan/bevy 0 10 #13

Closed joverwey closed 1 year ago

joverwey commented 1 year ago

Hi, I had to make some change locally to be compatible with Bevy 0.10.

I was also able to remove some code. The latest Bevy plugin code will only update the AssetServer if it hasn't already been initialized. So it is ok to continue calling the DefaultPlugin.

Something I did notice is that the call to surf::get() is very slow. About 20 seconds. This is when running natively, not wasm. Have you noticed the same or did I break something?

johanhelsing commented 1 year ago

No slow requests for me... web_image example loads in less than a second.

Are you also seeing this on the 0.9 version?

Also: to fix the lints, you just need to run cargo fmt

joverwey commented 1 year ago

Owner

It is slow on the 0.9 version too. Must be something with my network setup.

johanhelsing commented 1 year ago

Sorry, I kind of forgot about this PR... Merging since there are no regressions. If slow requests turns out to be a problem specific to this crate, let's open a new issue.