johanhelsing / bevy_web_asset

Bevy asset loader that transparently supports loading over http(s)
Apache License 2.0
71 stars 17 forks source link

Revision dependencies and fix compile errors for bevy 0.13 #26

Closed sbesh91 closed 6 months ago

sbesh91 commented 6 months ago

Quick PR here to ensure bevy 0.13 support

PS: my formatter seems to have run on the cargo.toml

johanhelsing commented 6 months ago

Thanks! What's the purpose of bumping web-sys?

sbesh91 commented 6 months ago

Thanks! What's the purpose of bumping web-sys?

In some conversation with folks in the Bevy discord they mentioned that they pin the version of web_sys because they don't follow semver with that package. I thought following that practice would be reasonable to do.

johanhelsing commented 6 months ago

Gotcha. I think what's done in this pr is just bumping the minimum requirement.

I think this would have been worked perfectly fine and handled automatically by cargo without that change, because bevy would then be the most specific dependency. If my understanding is correct.

It probably doesn't matter, but i just wanted to understand whats happening. Thanks for explaining.

sbesh91 commented 6 months ago

Gotcha. I think what's done in this pr is just bumping the minimum requirement.

I think this would have been worked perfectly fine and handled automatically by cargo without that change, because bevy would then be the most specific dependency. If my understanding is correct.

It probably doesn't matter, but i just wanted to understand whats happening. Thanks for explaining.

Thanks for the explanation on your end :100:

I don't have access to merge this with your approval, so I think you'll have to do that when you're ready.

sbesh91 commented 6 months ago

@johanhelsing are you able to trigger a release and new version? I didn't remember to do that in this PR. Sorry about that.

johanhelsing commented 6 months ago

Yep. Planning to do releases of this one and most of my crates tomorrow.

sbesh91 commented 6 months ago

Yep. Planning to do releases of this one and most of my crates tomorrow.

Thank you!

johanhelsing commented 6 months ago

@sbesh91 done :)