Closed sbesh91 closed 6 months ago
Thanks! What's the purpose of bumping web-sys?
Thanks! What's the purpose of bumping web-sys?
In some conversation with folks in the Bevy discord they mentioned that they pin the version of web_sys because they don't follow semver with that package. I thought following that practice would be reasonable to do.
Gotcha. I think what's done in this pr is just bumping the minimum requirement.
I think this would have been worked perfectly fine and handled automatically by cargo without that change, because bevy would then be the most specific dependency. If my understanding is correct.
It probably doesn't matter, but i just wanted to understand whats happening. Thanks for explaining.
Gotcha. I think what's done in this pr is just bumping the minimum requirement.
I think this would have been worked perfectly fine and handled automatically by cargo without that change, because bevy would then be the most specific dependency. If my understanding is correct.
It probably doesn't matter, but i just wanted to understand whats happening. Thanks for explaining.
Thanks for the explanation on your end :100:
I don't have access to merge this with your approval, so I think you'll have to do that when you're ready.
@johanhelsing are you able to trigger a release and new version? I didn't remember to do that in this PR. Sorry about that.
Yep. Planning to do releases of this one and most of my crates tomorrow.
Yep. Planning to do releases of this one and most of my crates tomorrow.
Thank you!
@sbesh91 done :)
Quick PR here to ensure bevy 0.13 support
.into()
to fix compile errors that surfaced after library upgradesPS: my formatter seems to have run on the cargo.toml