search

johanhelsing / matchbox

Painless peer-to-peer WebRTC networking for rust wasm (and native!)
Apache License 2.0
889 stars 73 forks source link

send queue is full #294

Closed simbleau closed 1 year ago

simbleau commented 1 year ago

I left my computer on when I went for a run. I think the tab wasn't selected, so it piled up a bunch of messages at once to send. In the span of a second or two I got thousands of log messages and quickly this happened.

image
garryod commented 1 year ago

I guess this begs the question, how should we deal with losing the ability to send messages (via loss of context or some other mechanism)? Were the WS messages still getting through to the signalling server or had we been disconnected at this point?

simbleau commented 1 year ago

Connection stayed active. I think they just got dropped on the client side.

simbleau commented 1 year ago

This should be fixed by #283 (escalate to a return of the message loop, rather than a "stack overflow" as a result of ignoring errors).

johanhelsing commented 1 year ago

If send queue is full in unreliable mode, we probably just want the loop to continue running, though?

simbleau commented 1 year ago

Yes, true.