johanhelsing / matchbox

Painless peer-to-peer WebRTC networking for rust wasm (and native!)
Apache License 2.0
888 stars 73 forks source link

Unreliable channels are actually reliable #338

Closed CouleeApps closed 8 months ago

CouleeApps commented 1 year ago

Due to https://github.com/webrtc-rs/webrtc/issues/371, trying to construct a data channel with RTCDataChannelInit::max_retransmits: Some(0) will actually produce a reliable (though unordered?) channel. After a bit of testing on my own, I found that even under significant packet loss, all packets sent on the unreliable channel still arrive and perfectly in order. I tried playing around with the parameters to RTCDataChannelInit and have not found a configuration yet that actually produces an unreliable channel.

With that being said, I guess the issue in this repo mostly revolves around:

I'm not sure what you want to do / what is even actionable from this, but it is still a downstream problem in this crate.


Reference for things I tried:

simbleau commented 1 year ago

This seems like a webrtc issue that will solve itself with time. Just needs more attention on the webrtc side. It seems there's 0 urgency on it, because no one is pointing out the issue in a pull request or a minimum reproducible example.

I'm not satisfied relying on or working around it. If you want to do that in your own code, you may.

simbleau commented 8 months ago

Closing because it's not our bug