johanhelsing / matchbox

Painless peer-to-peer WebRTC networking for rust wasm (and native!)

Apache License 2.0

864 stars 70 forks source link

Updated to Bevy 0.12 and latest Bevy GGRS #366

Closed bushrat011899 closed 9 months ago

bushrat011899 commented 9 months ago

Objective

Make the minimum changes required to support Bevy 0.12 and the latest version of Bevy GGRS.

Solution

Switched to Git version of GGRS
Switched to Git version of Bevy GGRS
Updated Box Game example to match newer Bevy GGRS API.

Notes

I've switched to Git versions of GGRS and Bevy GGRS. For a proper release, these should be changed to specific released versions.

johanhelsing commented 9 months ago

Fix for signaling feature: https://github.com/johanhelsing/matchbox/commit/e323de7a78839d4e8a16484a21a69e5d59ba1519

johanhelsing commented 9 months ago

Bevy_ggrs had a release so we can switch back from git :) Let's get a release out next week!

bushrat011899 commented 9 months ago

Bevy_ggrs had a release so we can switch back from git :) Let's get a release out next week!

All updated!

bushrat011899 commented 9 months ago

I'd never seen taplo before, quite a nice utility! I've installed it and I'll make sure to just run taplo fmt before making changes. I'd recommend the creation of a CONTRIBUTING.md file which includes things like "what to run before pushing a commit". That helped me a lot when I first started working on Bevy.

johanhelsing commented 9 months ago

I tried to fix taplo ci errors in #369, hopefully will be more straightforward to fix next time

johanhelsing commented 9 months ago

I'd never seen taplo before, quite a nice utility! I've installed it and I'll make sure to just run taplo fmt before making changes. I'd recommend the creation of a CONTRIBUTING.md file which includes things like "what to run before pushing a commit". That helped me a lot when I first started working on Bevy.

Good idea!