johanhelsing / matchbox

Painless peer-to-peer WebRTC networking for rust wasm (and native!)
Apache License 2.0
848 stars 67 forks source link

fix: [bevy_ggrs example] add tonemapping_luts bevy feature #418

Closed AgustinRamiroDiaz closed 5 months ago

AgustinRamiroDiaz commented 5 months ago

fixes https://github.com/johanhelsing/matchbox/issues/398

With the fix

image

Without the fix

image

Important caveat

This fix is only for WASM. The native compilation is still broken as per https://github.com/johanhelsing/matchbox/issues/417

Extra context

Seems that this was forgotten, because the dependency was added for bevy_matchbox https://github.com/AgustinRamiroDiaz/matchbox/blob/a70b27a5291cf0427e4312c75d6529625fe3e970/bevy_matchbox/Cargo.toml#L50

johanhelsing commented 5 months ago

Thanks. We've had quite a few similar issues... wondering if perhaps it's less of a hassle to simply depend on bevy with default-features, even if it produces huge binaries and takes a while to build. Anyway, not for this PR. /rant

Thanks for the fix!

simbleau commented 5 months ago

Thanks!