Deduplicate code, fix bug, prefer join() over +

johanholmerin / style9

CSS-in-JS compiler inspired by Meta's stylex

MIT License

570 stars 27 forks source link

Deduplicate code, fix bug, prefer join() over + #11

Closed geophree closed 4 years ago

geophree commented 4 years ago

Some code changes I did while exploring the codebase to understand it better. I'm happy to break them up into separate PRs, or make changes if you want.

Deduplicate prop expanding and formatting.
Factor out a reduceStyles() function to avoid duplication.
Fix keyframe rendering for empty frames.
Minimize string concatenation and joins.

Fixes #10

johanholmerin commented 4 years ago

Regarding deduplicating and refactoring, the code does need to be cleanup up, but I find the reduceStyles function to be too complicated. If you start by making a PR for fixing #10 we can then look at gradually simplifying the rest of the code.