search

johanjanssen / TemurinChocolateyPackages

Apache License 2.0
3 stars 4 forks source link

(adoptopenjdk) update to fix reversed urls #11

Closed RedBaron2 closed 4 years ago

RedBaron2 commented 4 years ago

@johanjanssen @johanjanssen-sanoma This is the patch to fix the reversed urls for some of the packages. It should work better than what had been done previously. This addresses issue #10 and should fix the issue in the future.

Just curious if I should work on making the script be able to do fixversion patch updates?

johanjanssen commented 4 years ago

Hi @RedBaron2 cool, thanks for the quick fix. I tested one of the packages which went wrong and it's good now. One question to be sure, the checksums were in the wrong order as well. They seem to be good now, that's probably because they aren't retrieved from the API but calculated?

I don't think it's really needed to change the script for patch updates. Most of the time it just works :). If something is wrong, I often prefer to fix it by hand. That's mostly quicker than debugging and fixing the script. The other issue with patches is with versioning. Chocolatey only allows a.b.c.d for versions. Some of the packages have three of them, so I can add ".1" for the patch. But some packages already have four of them, so I need to increment the last one.