search

johanjanssen / TemurinChocolateyPackages

Apache License 2.0
3 stars 4 forks source link

INSTALLDIR should be Eclipse Foundation instead of Temurin #19

Closed johanjanssen closed 2 years ago

johanjanssen commented 2 years ago

Small docu issue:

INSTALLDIR Default is %Programfiles%\Temurin ** It is actually %Programfiles%\Eclipse Foundation

RedBaron2 commented 2 years ago

@johanjanssen You could just have automation replace the line in the future. Replace the lines in the ReadMe.tmp file for the following

The next change needs to be done in the update.ps1 file

I hope this helps for this issue.

The next issue will be how to

I for one don't like the way the Temurin project is heading for the future. They are making a business financial decision without any care or concern for the security of the community. JDK have always been a less secure vector than JRE IMHO

johanjanssen commented 2 years ago

Thanks for the hints @RedBaron2 , will try to fix it when I have some more time.

For now, I don't have plans to create a custom JRE with a MSI installer as I simply don't have the time. Next to that, it would also require hosting them somewhere. If someone wants to use a JRE, then I recommend them using for instance the ones provided by Liberica, I created Chocolatey installers for them as well.

johanjanssen commented 2 years ago

Fixed for now by hardcoding the organization as I hope it won't change too often :)

Vankog commented 2 years ago

@johanjanssen Well, it is now "Temurin" again ^^ (except for 11 as I saw so far) So I suggest reverting this again. ;-)

However, "Temurin" is taken as the install dir directly, the sub-dirs are missing. The different Temurin packages are now overwriting each other.

johanjanssen commented 2 years ago

@Vankog how did you install the software? I've tried it and sub dirs are created. Only issue I see is that the main directory is Eclipse Adoptium instead of Eclipse Foundation.

choco install temurin8
...
  Software installed to 'C:\Program Files\Eclipse Adoptium\jdk-8.0.312.7-hotspot\'

choco install temurin17
...
  Software installed to 'C:\Program Files\Eclipse Adoptium\jdk-17.0.1.12-hotspot\'
johanjanssen commented 2 years ago

That name seems to come from the Adoptium project where they changed it. So I have to update the documentation again. For the rest it seems to work ok here.

Vankog commented 2 years ago

1. Issue of INSTALLDIR not working for temurin11:

I created a new issue for that -> #22

2. default dirs:

temurin8

PS C:\Users\FOOBAR> choco install Temurin8 --params="/ADDLOCAL=FeatureMain,FeatureEnvironment" -f -y
Chocolatey v0.11.3
Installing the following packages:
Temurin8
By installing, you accept licenses for the packages.
Temurin8 v8.312.700 already installed. Forcing reinstall of version '8.312.700'.
 Please use upgrade if you meant to upgrade to a new version.
Progress: Downloading Temurin8 8.312.700... 100%

Temurin8 v8.312.700 (forced) [Approved]
temurin8 package files install completed. Performing other installation steps.
WARNING: Using Default of C:\Program Files\Temurin
WARNING: Using Addlocal
WARNING: No InstallLevel detected. Defaulting to AddLocal
WARNING: Installing only Get-OSArchitectureWidth
Downloading Temurin8 64 bit
  from 'https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u312-b07/OpenJDK8U-jdk_x64_windows_hotspot_8u312b07.msi'
Progress: 100% - Completed download of C:\Users\dmoench\AppData\Local\Temp\chocolatey\Temurin8\8.312.700\OpenJDK8U-jdk_x64_windows_hotspot_8u312b07.msi (85.95 MB).
Download of OpenJDK8U-jdk_x64_windows_hotspot_8u312b07.msi (85.95 MB) completed.
Hashes match.
Installing Temurin8...
Temurin8 has been installed.
 The install of temurin8 was successful.
  Software installed to 'C:\Program Files\Temurin\jdk8-hotspot-8.312.7\'

temurin11

PS C:\Users\foobar> choco install Temurin11 --params="/INSTALLLEVEL=2" -f -y
Chocolatey v0.11.3
Installing the following packages:
Temurin11
By installing, you accept licenses for the packages.
Temurin11 v11.0.13.801 already installed. Forcing reinstall of version '11.0.13.801'.
 Please use upgrade if you meant to upgrade to a new version.
Progress: Downloading Temurin11 11.0.13.801... 100%

Temurin11 v11.0.13.801 (forced) [Approved]
temurin11 package files install completed. Performing other installation steps.
WARNING: Installing only Get-OSArchitectureWidth
Downloading Temurin11 64 bit
  from 'https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.13%2B8/OpenJDK11U-jdk_x64_windows_hotspot_11.0.13_8.msi'
Progress: 100% - Completed download of C:\Users\dmoench\AppData\Local\Temp\chocolatey\Temurin11\11.0.13.801\OpenJDK11U-jdk_x64_windows_hotspot_11.0.13_8.msi (166.97 MB).
Download of OpenJDK11U-jdk_x64_windows_hotspot_11.0.13_8.msi (166.97 MB) completed.
Hashes match.
Installing Temurin11...
Temurin11 has been installed.
 The install of temurin11 was successful.
  Software installed to 'C:\Program Files\Eclipse Adoptium\jdk-11.0.13.8-hotspot\'

temurin17

PS C:\Users\foobar> choco install Temurin17 --params="/ADDLOCAL=FeatureMain,FeatureEnvironment" -f -y
Chocolatey v0.11.3
Installing the following packages:
Temurin17
By installing, you accept licenses for the packages.
Temurin17 v17.0.1.1200 already installed. Forcing reinstall of version '17.0.1.1200'.
 Please use upgrade if you meant to upgrade to a new version.
Progress: Downloading Temurin17 17.0.1.1200... 100%

Temurin17 v17.0.1.1200 (forced) [Approved]
temurin17 package files install completed. Performing other installation steps.
WARNING: Using Default of C:\Program Files\Temurin
WARNING: Using Addlocal
WARNING: No InstallLevel detected. Defaulting to AddLocal
Downloading Temurin17 64 bit
  from 'https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.1%2B12/OpenJDK17U-jdk_x64_windows_hotspot_17.0.1_12.msi'
Progress: 100% - Completed download of C:\Users\dmoench\AppData\Local\Temp\chocolatey\Temurin17\17.0.1.1200\OpenJDK17U-jdk_x64_windows_hotspot_17.0.1_12.msi (160.73 MB).
Download of OpenJDK17U-jdk_x64_windows_hotspot_17.0.1_12.msi (160.73 MB) completed.
Hashes match.
Installing Temurin17...
Temurin17 has been installed.
 The install of temurin17 was successful.
  Software installed to 'C:\Program Files\Temurin\jdk17-hotspot-17.0.1.12\'

OK... for whatever reason, the issue of them all being installed into the root of "\Temurin" (#20) does not appear anymore. I have no idea what went wrong the last time.

However, conclusion is:
8 and 17 install into \Temurin"
11 installs into "\Eclipse Adoptium"

used installation env:

PowerShell 7.2.1 (Win Store version) with

johanjanssen commented 2 years ago

Dirs Temurin and Eclipse Adoptium changed because of naming changes. Should be the same for all versions now.