search

johanjanssen / TemurinChocolateyPackages

Apache License 2.0
3 stars 4 forks source link

Install script sometimes contains unused variables #2

Closed johanjanssen closed 4 years ago

johanjanssen commented 4 years ago

Remove unused variables from install scripts.

For instance the following package: https://chocolatey.org/packages/adoptopenjdk13openj9/13.33

Has the following install script:

$packageArgs = @{ PackageName = 'AdoptOpenJDK13openj9' Url = '' Url64bit = 'https://github.com/AdoptOpenJDK/openjdk13-binaries/releases/download/jdk-13%2B33_openj9-0.16.0/OpenJDK13U-jdk_x64_windows_openj9_windowsXL_13_33_openj9-0.16.0.msi' Checksum = '' ChecksumType = '' Checksum64 = 'A203B113F2ADF4D49C6C0FEF3E36C08F40C1F0B6D38CD224249F95C978FAF215' ChecksumType64 = 'sha256' fileType = 'msi' silentArgs = "INSTALLLEVEL=3 /quiet" }

johanjanssen commented 4 years ago

Partly caused by a third downloadlink for WindowsXL (large heap). This is fixed.

One issue remains: OpenJ9 except for Java 8 doesn't have 32 bit downloads.

johanjanssen commented 4 years ago

Fixed by #6