search

johanjanssen / TemurinChocolateyPackages

Apache License 2.0
3 stars 4 forks source link

Packages installed in wrong directory #29

Closed naliferopoulos closed 1 year ago

naliferopoulos commented 1 year ago

I have noticed that the Temurin11 package is now installed in a different directory than the expected. By skimming through the install helper I expected the installation directory to be the following (for x64):

C:\Program FIles\Temurin

Instead packages are installed to:

C:\Program Files\Eclipse Adoptium

The latter is mentioned as default in the Eclipse Adoptium MSI installer documentation. I also seem to recall this to have been caused by a recent upgrade of Temurin11. Could it perhaps be related to changes on the MSI installer behavior?

johanjanssen commented 1 year ago

Hi Nick,

Indeed, the default directory is set by the MSI installer. I think it was Temurin quite some time ago, but they already changed it more than a year ago. Also see https://github.com/johanjanssen/TemurinChocolateyPackages/issues/19 where we changed the documentation for the Chocolatey package to incorporate the new installation directory.

If you look on https://community.chocolatey.org/packages/Temurin11 it mentions: Note: You must use INSTALLDIR with FeatureMain. INSTALLDIR Default is $env:Programfiles\Eclipse Adoptium

So I don't think this is a bug? Maybe the install helper could be changed a bit to make it more clear, but I guess most people don't even look at the code :).

naliferopoulos commented 1 year ago

Oh sorry about that! I thought it was intended to be installed to Temurin, that's why I opened an issue! I somehow managed to miss that it is documented! Thanks for your reply!

johanjanssen commented 1 year ago

No problem, I also had some problems with the different names (Temurin/Eclipse Adoptium) in the past, it's quite confusing :).