search

johanjanssen / TemurinChocolateyPackages

Apache License 2.0
3 stars 4 forks source link

(AdoptOpenJDK) Wording and switch cleanup #9

Closed RedBaron2 closed 4 years ago

RedBaron2 commented 4 years ago

@johanjanssen @johanjanssen-sanoma The following are changes that need to be made to the wording of the readme. The changes to the switches to work correctly all the time.

I have looked into an issue related to #7 and filed it here This issue makes the example even on AdoptOpenJDK website not work correctly. I feel that due to this issue a preferred method of using the INSTALLLEVEL is recommended.

Thanks for looking into this PR.

johanjanssen commented 4 years ago

Wanted to merge this one, but noticed that you're issue got a reply that it might be about quoting. Did you already try that one?

RedBaron2 commented 4 years ago

@johanjanssen I updated my local version with a change for the processing of the installdir variable. It installs without complaints. I'll update this PR tomorrow hopefully.

RedBaron2 commented 4 years ago

@johanjanssen Adjustments made and fixed the spacing issue with helper

johanjanssen commented 4 years ago

@RedBaron2 thanks a lot for the fixes!